fix(caldav): avoid selecting every custom properties from table if we have no calendars to filter #55651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
CarlSchwan,
ChristophWurst,
icewind1991,
nfebe,
st3iny and
yemkareems
and removed request for
a team,
nfebe and
yemkareems
tcitworld
added
bug
3. to review
SebastianKrupinski
approved these changes
Oct 9, 2025
Contributor
|
/rebase |
st3iny
approved these changes
Oct 9, 2025
… have no calendars to filter Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
fix-calendars-properties-cache
branch
from
e120eb1 to
22b90c2
Compare
Member
Author
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the
$calendarsarray is empty, we just select the whole properties from the tables, which makes no sense and leads to performance issues.Checklist
3. to review, feature component)stable32)